Skip to content

feat(source map): more population for hover info#1852

Open
a-nosnitram wants to merge 4 commits into
mainfrom
feat/source-map/more-population
Open

feat(source map): more population for hover info#1852
a-nosnitram wants to merge 4 commits into
mainfrom
feat/source-map/more-population

Conversation

@a-nosnitram

@a-nosnitram a-nosnitram commented May 25, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fills in missing hover population in the parser SourceMap for docs-backed keywords.

  • domain substructure details (tuple, matrix, record, set)
  • quantifier/aggregate keywords (forAll, exists, sum, min, max)

Related issues

Closes Issue #1585

Key changes

  • parser/domain.rs

    • Integer range hover now uses documented key:
      • int_range nodes -> range
      • .. separator token -> range
    • Tuple domain hover now consistently uses docs key L_tuple (including parenthesised tuple form), while retaining arity metadata.
    • keyword hover for matrix (docs-backed).
    • Added docs-backed hover for set attribute keywords:
      • size -> L_size
      • minSize -> L_minSize
      • maxSize -> L_maxSize
  • parser/comprehension.rs

    • Added docs-backed operator hover only where docs exist:
      • min -> min
      • max -> max
    • No hover is added for undocumented operator keys (forAll, exists, sum).
  • parser/domain.rs cleanup
    -u32 conversion before Node::child(...) index access.

How to test/review

  • run extension.ts
  • test on essence files, hover on keywords mentioned above
Screenshot 2026-05-25 at 16 38 30 Screenshot 2026-05-25 at 17 42 34

@a-nosnitram a-nosnitram self-assigned this May 25, 2026
@github-project-automation github-project-automation Bot moved this to Story 1 in Frontend May 25, 2026
@a-nosnitram a-nosnitram changed the title Feat/source map/more population feat(source map): more population for hover info May 25, 2026
@a-nosnitram a-nosnitram moved this from Story 1 to Review in Frontend May 25, 2026
@a-nosnitram a-nosnitram linked an issue May 25, 2026 that may be closed by this pull request
@a-nosnitram
a-nosnitram marked this pull request as ready for review May 25, 2026 13:54
@a-nosnitram
a-nosnitram marked this pull request as draft May 25, 2026 13:55
@conjure-bot

conjure-bot Bot commented May 25, 2026

Copy link
Copy Markdown

Code Coverage

Report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1852/coverage-code/index.html
Diff report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1852/coverage-code/diff-coverage.html

This PR: 73.66% lines (22461/30494)
Diff: 90.00% lines (54/60 measured; 75 changed)
Main: 73.63% lines (22412/30439)
Delta vs main: +0.03 pp

@conjure-bot

conjure-bot Bot commented May 25, 2026

Copy link
Copy Markdown

RustDoc Coverage

Report: https://conjure-cp.github.io/conjure-oxide-reports/pr/1852/coverage-docs/index.html

This PR: 43.44% documented, 2.95% with examples (38/560/1289)
Main: 43.44% documented, 2.95% with examples (38/560/1289)
Delta: docs +0.00 pp, examples +0.00 pp

@a-nosnitram
a-nosnitram marked this pull request as ready for review May 25, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

hover info incomplete for some symbols / keywords

1 participant