feat: add multi-namespace support #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm/templates/service.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: Role | |||
| kind: ClusterRole | |||
Member
There was a problem hiding this comment.
If namespaces are specified, this should probably be a for loop to create the role and role binding in each namespace, rather than granting full cluster permissions
You should probably make the permissions block a reusable template though
helm/templates/service.yaml
Outdated
Comment on lines
79
to
80
| - name: CODER_NAMESPACES | ||
| value: {{ if .Values.namespaces }}{{ join "," .Values.namespaces }}{{ else }}{{ end }} |
Member
There was a problem hiding this comment.
Suggested change
| - name: CODER_NAMESPACES | |
| value: {{ if .Values.namespaces }}{{ join "," .Values.namespaces }}{{ else }}{{ end }} | |
| {{ if .Values.namespaces -}} | |
| - name: CODER_NAMESPACES | |
| value: "{{ join "," .Values.namespaces }}" | |
| {{ end -}} |
|
|
||
| // init starts the informer factory and registers event handlers. | ||
| func (p *podEventLogger) init() error { | ||
| func (p *podEventLogger) initNamespace(namespace string) error { |
Member
There was a problem hiding this comment.
Should include a sentence in the method comment explaining the namespace parameter
deansheather
approved these changes
Aug 25, 2025
| namespace: "" | ||
| # namespace -- List of namespaces to search for Pods within. | ||
| # If unspecified or empty it will watch all namespaces. | ||
| namespaces: [] |
Member
There was a problem hiding this comment.
This is breaking so make sure you inform customers in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multi-namespace support to coder-logstream-kube, allowing users to monitor pod events across multiple namespaces or all namespaces in a cluster. This replaces the previous single-namespace limitation.
Closes #5
Changes
--namespacesflag orCODER_NAMESPACESenvironment variableKubernetes RBAC Updates
Configuration Changes
values.yamlto usenamespacesarray instead of singlenamespacestringCODER_NAMESPACEtoCODER_NAMESPACES(comma-separated)--namespaceflag to--namespaceswith comma-separated supportExample
Breaking Changes
CODER_NAMESPACEis replaced withCODER_NAMESPACES--namespaceis replaced with--namespacesnamespacestring is replaced withnamespacesarray