Skip to content

Conversation

@jakehwll
Copy link
Contributor

This pull-request tightens up our biome.jsonc configuration a little. We've added useConsistentCurlyBraces to ensure that PR's like #21323 (and quite a few of my own, with my bad habit) don't get caught with having braces around props that don't require it.

Per the documentation:

// invalid
<Foo>{'Hello world'}</Foo>
<Foo foo={'bar'} />
<Foo foo=<Bar /> />
// valid
<Foo>Hello world</Foo>
<Foo foo="bar" />
<Foo foo={5} />
<Foo foo={<Bar />} />

Furthermore, there seemed to be a funky formatting issue on lines 44 and 45, I indented these to match.

@jakehwll jakehwll requested review from aslilac and jaaydenh and removed request for jaaydenh December 23, 2025 02:06
@jakehwll jakehwll requested a review from jaaydenh December 23, 2025 02:08
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! merry christmas for us!!

@jakehwll jakehwll merged commit df6b316 into main Dec 24, 2025
31 checks passed
@jakehwll jakehwll deleted the jakehwll/chore-consistent-curly-braces branch December 24, 2025 01:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants