fix: isolate keyring usage by parallel test processes #21256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures keyring tests that utilize the real OS keyring use credentials that are isolated by process ID so that parallel test processes do not access the same credentials.
ethanndickson
approved these changes
Dec 15, 2025
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| return fmt.Sprintf("%s_%v_%d", t.Name(), time.Now().UnixNano(), n) |
Member
There was a problem hiding this comment.
The flake was on Windows, and the Windows clock does have infamously poor precision (https://github.com/search?q=org%3Acoder+windows+clock+flake&type=issues, so I'm inclined to believe your hypothesis of multiple instances of the job running on the same Windows machine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures keyring tests that utilize the real OS keyring use credentials that are isolated by process ID so that parallel test processes do not access the same credentials.
coder/internal#1192