feat: add workspace sharing indicator #21222
Merged
+238
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Dec 11, 2025
Member
aslilac
left a comment
There was a problem hiding this comment.
code looks good, but design wise...
- in the original design, the settings link was a button
- I feel like things look a little vertically cramped. could we add just a bit more gap/padding in between?
629e5b4 to
73a619c
Compare
Contributor
Author
|
@aslilac I was referencing the new designs created by christin, https://www.figma.com/design/CNr6qGcPhbq3Qut6rENz6i/Shared-Workspaces?node-id=168-3958&t=Ga6q3znU5CzyVLZO-1 Good catch on the settings button, I changed this because of the designs but I actually think the button is the correct UI here. 
|
73a619c to
a50b597
Compare
Base automatically changed from
geokat/internal-858-sharing-info-in-workspaces-response
to
main
December 15, 2025 16:42
…paces_expanded view Instead of N+1 in coderd.
…_with: []` in response if experiment was enabled
162f4b8 to
8d4ccbf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.