Skip to content

Conversation

@bpmct
Copy link
Member

@bpmct bpmct commented Dec 9, 2025

Summary

This PR addresses David's review comments from PR #21153 to improve the Documentation Style Guide.

Changes

  • Research section: Updated to focus on reading "recent documentation" instead of "10+ similar pages" - more practical guidance
  • Premium Feature Callout: Clarified that the manifest.json badge addition should happen in docs/manifest.json
  • Screenshot Guidelines: Added context that this is for when screenshots "don't exist yet", making it clearer this is a temporary measure
  • Tabs documentation: Expanded explanation to clarify when tabs are appropriate (parallel content paths)
  • Coder registry: Added mention of referencing Coder registry URLs for cross-linking to external Coder resources

All changes maintain the existing documentation structure while improving clarity and specificity based on review feedback.

Refs #21153

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Address David's feedback from PR #21153:
- Update research section to focus on recent documentation
- Clarify Premium Feature Callout mentions manifest.json badge
- Add Screenshot Guidelines about when screenshots don't exist yet
- Update Tabs documentation to explain when to use them
- Add mention of referencing Coder registry for cross-links

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@bpmct bpmct requested a review from david-fraley December 9, 2025 00:40
@bpmct bpmct marked this pull request as ready for review December 9, 2025 00:40
- Add blank line before list after 'When documenting with screenshots'
- Fix nested code block examples using quadruple backticks
- Resolves markdownlint MD032, MD031, and MD040 errors
Copy link
Collaborator

@david-fraley david-fraley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. FYI I'm not seeing a comment around the redirects file, but that doesn't need to block merging

I think a comment around the redirects file not working would be good -- #21144

@bpmct bpmct merged commit 244e6ca into main Dec 9, 2025
29 checks passed
@bpmct bpmct deleted the docs/address-docs-style-guide-review-comments branch December 9, 2025 02:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
@matifali
Copy link
Member

matifali commented Dec 9, 2025

Premium in header is ony useful for H2 and below headings fro H1 it automatically comes up if it is present in docs/manifest.json

See this page for example: https://coder.com/docs/ai-coder/ai-bridge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants