Skip to content

chore: fix test errors on newer debian-based systems due to deprecated TZ #21115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geokat merged 1 commit into from
Dec 10, 2025
+7 −7
Merged

chore: fix test errors on newer debian-based systems due to deprecated TZ #21115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coderd/database/dbtestutil/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func NewDBWithSQLDB(t testing.TB, opts ...Option) (database.Store, pubsub.Pubsub
return db, ps, sqlDB
}

var DefaultTimezone = "Canada/Newfoundland"
var DefaultTimezone = "America/St_Johns"

// NowInDefaultTimezone returns the current time rounded to the nearest microsecond in the default timezone
// used by postgres in tests. Useful for object equality checks.
Expand Down
2 changes: 1 addition & 1 deletion coderd/database/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4082,7 +4082,7 @@ func TestGetUserStatusCounts(t *testing.T) {
t.Skip("https://github.com/coder/internal/issues/464")

timezones := []string{
"Canada/Newfoundland",
"America/St_Johns",
"Africa/Johannesburg",
"America/New_York",
"Europe/London",
Expand Down
10 changes: 5 additions & 5 deletions coderd/workspacestats/activitybump_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ func Test_ActivityBumpWorkspace(t *testing.T) {
// We test the below in multiple timezones specifically
// chosen to trigger timezone-related bugs.
timezones := []string{
"Asia/Kolkata", // No DST, positive fractional offset
"Canada/Newfoundland", // DST, negative fractional offset
"Europe/Paris", // DST, positive offset
"US/Arizona", // No DST, negative offset
"UTC", // Baseline
"Asia/Kolkata", // No DST, positive fractional offset
"America/St_Johns", // DST, negative fractional offset
"Europe/Paris", // DST, positive offset
"US/Arizona", // No DST, negative offset
"UTC", // Baseline
}

for _, tt := range []struct {
Expand Down
Loading