perf: optimize migration 371 to run faster on large deployments #20906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Nov 24, 2025
coderd/database/migrations/000371_api_key_scopes_array_allow_list.up.sql
Outdated
Show resolved
Hide resolved
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Nov 25, 2025
closes #20899 This is in response to a migration in v2.27 that takes very long on deployments with large `api_key` tables.
5f4307d to
47bba5b
Compare
Emyrk
approved these changes
Nov 25, 2025
Member
Emyrk
left a comment
There was a problem hiding this comment.
This looks good! I'll stamp after a meeting about this Wednesday morning CST
Emyrk
requested changes
Nov 25, 2025
Member
Emyrk
left a comment
There was a problem hiding this comment.
Just blocking a merge for now. Will stamp again
dannykopping
approved these changes
Nov 26, 2025
Emyrk
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20899
This is in response to a migration in v2.27 that takes very long on deployments with large
api_keystables.NOTE: The optimization causes the up migration to delete old data (keys that expired more than 7 days ago). The down migration won't resurrect the deleted data.