Skip to content

Conversation

@mtojek
Copy link
Member

@mtojek mtojek commented Nov 21, 2025

Updates #17917

This PR adds another tab to the Template page, which should be visible for Premium licenses and template admins.

Screenshot 2025-11-24 at 18 27 36

In the follow-up, I'll update the docs.

@mtojek mtojek self-assigned this Nov 21, 2025
@mtojek mtojek marked this pull request as ready for review November 24, 2025 18:02
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, aside from minor fixes including updating the API endpoint middleware to check for the prebuilds feature entitlement instead of template RBAC.

One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.

Screenshot 2025-11-26 at 12 29 06

mtojek added a commit that referenced this pull request Nov 26, 2025
@mtojek mtojek marked this pull request as draft November 26, 2025 15:51
Copy link
Member Author

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.

This is a valid call, but it involves modifying the workspaces endpoint, so definitely another issue/pull request 👍 Thanks for the suggestion!

@mtojek mtojek marked this pull request as ready for review November 27, 2025 11:15
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Nice work 🎉

@mtojek mtojek merged commit a8862be into main Nov 28, 2025
31 of 33 checks passed
@mtojek mtojek deleted the 17917-invalidation-ui-2 branch November 28, 2025 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants