-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(site): add tab to invalidate prebuilds #20864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPage.tsx
Outdated
Show resolved
Hide resolved
ssncferreira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, aside from minor fixes including updating the API endpoint middleware to check for the prebuilds feature entitlement instead of template RBAC.
One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/TemplatePage/TemplatePrebuildsPage/TemplatePrebuildsPageView.stories.tsx
Show resolved
Hide resolved
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.
This is a valid call, but it involves modifying the workspaces endpoint, so definitely another issue/pull request 👍 Thanks for the suggestion!
ssncferreira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ Nice work 🎉
Updates #17917
This PR adds another tab to the Template page, which should be visible for Premium licenses and template admins.
In the follow-up, I'll update the docs.