fix: improve http connection pooling for smtp notifications #20605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Nov 10, 2025
cli/exp_scaletest_notifications.go
Outdated
| smtpHTTPTransport := &http.Transport{ | ||
| MaxConnsPerHost: 512, | ||
| MaxIdleConnsPerHost: 512, | ||
| MaxIdleConns: 2048, |
Contributor
There was a problem hiding this comment.
What's the purpose of setting both this and a per-host value?
Contributor
Author
There was a problem hiding this comment.
That was left over from my earlier tests. I forgot that MaxIdleConns is unlimited by default, so MaxIdleConnsPerHost is enough. Fixed.
spikecurtis
approved these changes
Nov 10, 2025
bb67e96 to
188da9b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates how SMTP notifications are polled during scale tests.
Before, each of the ~2,000 pollers created its own http.Client, which opened thousands of short-lived TCP connections.
Under heavy load, this ran out of available network ports and caused errors like
connect: cannot assign requested addressNow, all pollers share one HTTP connection pool. This prevents port exhaustion and makes polling faster and more stable.
If a network error happens, the poller will now retry instead of stopping, so tests keep running until all notifications are received.
The
SMTPRequestTimeoutis now applied per request using a context, instead of being set on thehttp.Client.