feat: add AWS Bedrock support #20507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
9b65c6a to
130eb7a
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
deansheather
approved these changes
Oct 28, 2025
Comment on lines
+51
to
+53
| if cfg.Region.String() == "" && cfg.AccessKey.String() == "" && cfg.AccessKeySecret.String() == "" { | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
The code in aibridge returned an error if model or small fast model wasn't set either. It's unlikely it won't be set since there is a default value, but technically it could still be unset by the user so you should still check that it's not empty here
Contributor
Author
There was a problem hiding this comment.
No need to do that here I think. There's validation that the model/small-fast-model are set when creating a client; this is just determining whether Bedrock is configured or not.
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on coder/aibridge#44
Closes coder/aibridge#28