feat: add workspace build status to task page #18520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25c41d7 to
cb7a768
Compare
cb7a768 to
f9045a9
Compare
hugodutka
approved these changes
Jun 24, 2025
Contributor
hugodutka
left a comment
There was a problem hiding this comment.
Nice! Minor nits:
- can we remove the "this should take a few minutes" text? it's redundant now that we have the progress indicator
- can we put "Starting workspace..." and "Up to X seconds remaining..." on separate lines?
Member
Author
Good point! Done.
How is this? |
Contributor
|
It'd look a bit better if the text was centered and the progress bar was at the bottom |
Member
Author
|
Hmm actually the "starting workspace..." part is also redundant, let me remove that instead of stacking the two lines. |
Member
Author
|
Here it is at the bottom, wdyt about right vs center when it is at the bottom? I kinda like right but could go either way.
|
Member
Author
|
Another possibility, I like the remaining time near the progress bar though personally
|
Contributor
|
|
And remove the duplicate "Starting workspace..." text.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might need to be rebased on the latest changes,(done) but this adds a progress bar and the most recent build stage.I only did this for workspaces starting up, but we could do it for when the workspace is shutting down as well.
Although I tried adding a story for the build log, the mock web socket keeps closing in Storybook before it gets any logs, so I had to skip it. Not sure what is going on there...
recording.mp4
Closes #18183