feat: migrate Alert component from MUI to shadcn and update to new Alert designs #18412
Conversation
|
I definitely want to see this happen, but even just looking at the first few stories I see a number of things that aren't quite right. not sure how to get blink to fix any of this without eyes. |
|
@aslilac sorry about the noise, my intention was only to reopen this and test out coder tasks on cleaning it up. I didn't explicitly set it ready for review or request your review. I wonder if that could have happened automatically somehow or if Claude (through coder tasks) was able to do that itself. Maybe it has something to do with you being a codeowner? |
|
yeah, I think CODEOWNERs only kicks in when you mark it as ready. no worries tho, just lmk when you'd like a review! |
fdc83a5 to
a8ecfd4
Compare
- Replace MUI Alert with shadcn-based implementation using class-variance-authority - Maintain backward compatibility with existing Alert API (severity, dismissible, actions, onDismiss) - Update AlertTitle imports across codebase to use new implementation - Add proper Tailwind CSS styling with dark mode support - Preserve accessibility features and smooth animations - Support all existing severity levels: info, success, warning, error Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
ce82813 to
83eb68c
Compare
aslilac
left a comment
There was a problem hiding this comment.
just one note:
it seems like there's a lot of usage of this new prominent prop. would it be better to flip the default and requiring opting in to a more subtle alert?
--- Although originally created with Blink most of the PR has been re-written since then
Summary
This PR migrates the Alert component from MUI to shadcn implementation while maintaining full backward compatibility with the existing API. Updates Alerts to new design in Figma.
Figma design: https://www.figma.com/design/WfqIgsTFXN2BscBSSyXWF8/Coder-kit?node-id=3522-3005&m=dev