fix: handle workspace.agent and agent.workspace.owner in coder ssh
#18093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of the ssh command input format by adding support for the "workspace.agent" and "agent.workspace.owner" formats, ensuring parity with the existing Coder Connect workflow.
- Updated SSH tests (cli/ssh_test.go) with new cases such as "myworkspace.dev" and "dev.myworkspace.myuser"
- Modified the workspace normalization logic in cli/ssh.go to correctly transform the new input formats
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/ssh_test.go | Added new test cases for handling "workspace.agent" and "agent.workspace.owner" formats |
| cli/ssh.go | Updated input normalization to support the new formats through specific conditional logic |
Comments suppressed due to low confidence (1)
cli/ssh_test.go:117
- Include an assertion comment or additional explicit test expectations for the normalized output of this new input format to verify that the transformation to 'owner/workspace.agent' is correct.
"dev.myworkspace.myuser",
99db25d to
df1ec50
Compare
Member
|
Would this also support |
Member
Author
|
With this PR: |
deansheather
approved these changes
May 29, 2025
Member
|
/cherry-pick release/2.22 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18088.
The linked issue is misleading --
coder config-sshcontinues to support thecoder.prefix. The reason the commandssh coder.workspace.agentfails is becausecoder ssh workspace.agentwasn't supported. This PR fixes that.We know we used to support
workspace.agent, as this is what we (used to) recommend in the Web UI:This PR also adds support for
coder ssh agent.workspace.owner, such that after runningcoder config-ssh, a command likeworks, even without Coder Connect running. This is done for parity with an existing workflow that uses
ssh workspace.coder, which either uses Coder Connect if available, or the CLI.