feat: remove site wide perms from creating a workspace #17296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a workspace requires `read` on site wide `user`. Added unit tests to assert this
aslilac
reviewed
Apr 8, 2025
aslilac
approved these changes
Apr 9, 2025
Collaborator
|
/cherry-pick release/2.21 |
Member
|
/cherry-pick release/2.20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a workspace required
readon site wideuser.Only organization permissions should be required.
Added unit tests to assert this
Permissions required to create a workspace for another user. We might want to revist the required permissions at some point.
coder/enterprise/coderd/workspaces_test.go
Lines 269 to 272 in d40ec9c