fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults #16303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace_tag defaults
…nalProvisionerDaemon
b4f9bec to
85a168e
Compare
Emyrk
approved these changes
Jan 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a check we previously had requiring all workspace tag values sniffed in
tfparseto have a non-empty value. This allows template authors to provide an initially empty value that is later overriden with tag values either in the request or passed in via template variables when importing the template.Also updates documentation removing references to the non-empty default value requirement.
Also addresses an issue in our test code for starting a new external provisioner that causes an error if the test name is longer than 64 characters, which is longer than our DB schema allows.
Screen.Recording.2025-01-27.at.21.21.03.mov