fix: display build timings when all timings are loaded #15728
Merged
+43
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenos-nachos
approved these changes
Dec 3, 2024
Contributor
buenos-nachos
left a comment
There was a problem hiding this comment.
Looks good! Had one question to make sure I'm properly understanding something, but it's tiny and shouldn't cause any problems
Comment on lines
173
to
176
| const expectedScriptTimingsCount = workspace.latest_build.resources | ||
| .flatMap((r) => r.agents) | ||
| .flatMap((a) => a?.scripts) | ||
| .filter((s) => s !== undefined).length; |
Contributor
There was a problem hiding this comment.
Tiny nit, but I want to say this can be cleaned up as:
const expectedScriptTimingsCount = workspace.latest_build.resources
.flatMap((r) => r.agents)
.flatMap((a) => a?.scripts ?? []).length;| "workspaceBuilds", | ||
| workspaceBuildId, | ||
| "timings", | ||
| { readyAgentsCount }, |
Contributor
There was a problem hiding this comment.
What was the readyAgentCount value doing before? I see that we were only using it for the query key, and now it's gone
Contributor
Author
There was a problem hiding this comment.
It was to refetch the query when a new agent was marked as ready but it was very buggy and a bad decision on my end. The current refetch logic makes more sense and it is easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15273