Skip to content

Conversation

@ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 10, 2024

Without this, any codersdk consumers would need to add our tailscale/gvisor go.mod replaces to run go test or go mod tidy. Of note is that go mod tidy needs to succeed for goreleaser to work, so something like the coderd provider couldn't be released.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review September 10, 2024 10:47
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson merged commit 2a9234e into main Sep 10, 2024
@ethanndickson ethanndickson deleted the 09-10-fix_remove_coderdtest_dependency_from_codersdk branch September 10, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants