minor fixes

evgeniy-scherbina · evgeniy-scherbina · commit 80e52ee03f68 · 2025-06-12T18:54:40.000Z
diff --git a/enterprise/coderd/prebuilds/reconcile.go b/enterprise/coderd/prebuilds/reconcile.go
@@ -619,14 +619,17 @@ func (c *StoreReconciler) executeReconciliationAction(ctx context.Context, logge
 		// Unexpected things happen (i.e. bugs or bitflips); let's defend against disastrous outcomes.
 		// See https://blog.robertelder.org/causes-of-bit-flips-in-computer-memory/.
 		// This is obviously not comprehensive protection against this sort of problem, but this is one essential check.
-		// TODO: uncomment:
-		// desired := ps.Preset.DesiredInstances.Int32
-		// if action.Create > desired {
-		//	logger.Critical(ctx, "determined excessive count of prebuilds to create; clamping to desired count",
-		//		slog.F("create_count", action.Create), slog.F("desired_count", desired))
-		//
-		//	action.Create = desired
-		//}
+		desired, err := ps.CalculateDesiredInstances(c.clock.Now())
+		if err != nil {
+			return xerrors.Errorf("failed to calculate desired instances: %w", err)
+		}
+
+		if action.Create > desired {
+			logger.Critical(ctx, "determined excessive count of prebuilds to create; clamping to desired count",
+				slog.F("create_count", action.Create), slog.F("desired_count", desired))
+
+			action.Create = desired
+		}
 
 		// If preset is hard-limited, and it's a create operation, log it and exit early.
 		// Creation operation is disallowed for hard-limited preset.
