Add docker-compose file as example#680
Add docker-compose file as example#680code-asher merged 4 commits intocoder:masterfrom marc-x-andre:feature/docker_compose
Conversation
|
With docker-compose, would it be trivial to add https with certbot for example purposes ? |
It could be easy, but I don't think it is in the scope of the example. The goal was to reproduce the docker command in the README: |
frank-dspeed
left a comment
There was a problem hiding this comment.
this should also mount the extension directorys so they get persisted
docker-compose.yml
Outdated
| - "${PWD}:/home/coder/project" | ||
| environment: | ||
| PASSWORD: ${PASSWORD} | ||
| command: --allow-http --no-auth |
There was a problem hiding this comment.
You have PASSWORD env var, but it will not work, because the --no-auth flag is set.
There was a problem hiding this comment.
Should add a comment here indicating that you need to remove --no-auth with a docker-compose override file or edit this one if you want to use $PASSWORD.
|
Obsoleted by GH-857. Please rebase this to the newer tree. |
|
@sr229 why is this obsolete? There is no merge conflict. |
|
I manually changed it to v2 flags. I'll work on this so it can be merged. |
use has been deprecated for a while now.
|
CC @code-asher feel free to merge this in or cherrypick. |
Describe in detail the problem you had and how this PR fixes it
There wasn't an example of how to use
docker-composewith code-server.Is there an open issue you can link to?
Yes. docker-compose examples #648
Fixes #648.