Conversation
778d878 to
616b1da
Compare
timabrmsn
reviewed
Oct 7, 2022
setup.py
Outdated
| install_requires=[ | ||
| "chardet", | ||
| "click>=7.1.1, <8", | ||
| "click>=8.0.0, <8.1.0", |
Contributor
There was a problem hiding this comment.
We don't need to have an upper-limit here. If someone is still running python 3.6 click>=8.1.0 simply won't get installed for them. And if 8.1.+ doesn't break anything in our code we don't need to artificially limit it if they are on 3.7+
Contributor
There was a problem hiding this comment.
and we can also keep it >=7.1.1 since we're not depending on anything 8+ specific.
Contributor
Author
There was a problem hiding this comment.
our unit tests will fail on 7.1.1 by error message assertion but are we okay with that because it doesn't affect the actual user?
Contributor
There was a problem hiding this comment.
We could just make the asserts be an or, like
assert ("Could not open file: not_a_file" in result.stdout) or (" Invalid value for '--advanced-query': 'not_a_file': No such file or directory" in result.stdout)
Contributor
Author
There was a problem hiding this comment.
I have no idea why I didn't think of that
timabrmsn
approved these changes
Oct 10, 2022
1e81479 to
561bd4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update click to latest major version >=8.0.0. Updated to
v8.0.4. This major version was released in spring of 2021.It appears that the only changes that affected the CLI tests is trivial changes in error messages. That being said the list of changes is significant so I'm going to read through it carefully before release to make sure we didn't miss anything.
Worth noting that click 8.1.0 removes support for python <3.7 so we would have to up our python version requirement before further updating.