Mukeunzi & Jin step4-1 Refactoring#83
Merged
crongro merged 11 commits intocode-squad:mukeunzifrom Apr 16, 2019
Merged
Conversation
todo의 생성자함수로 makeNewTodo 대체
show(), printStatus()
printAll과 printStatus에 return을 넣어 log를 한번만 호출하게 구조변경
충돌을 머지로 해결
crongro
approved these changes
Apr 16, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
수고했네요.
Class를 쓴 김에 Class를 좀더 공부하면 더 좋겠네요.
보통은 constructor에서 로직을 구현하진 않습니다. (객체를 생성하는 단계라서 생성에 집중하는 것이죠)
| class Todo { | ||
| constructor(todos) { | ||
| this.todos = todos; | ||
| this.customTodos = todos.reduce( |
Contributor
There was a problem hiding this comment.
customTodos라는 것이 의미하는 것을 변수명으로는 알기 어렵네요.
setTodoCount() 라는 메서드를 만들고, 여기 코드를 옮기는 건 어때요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step4-1 리팩토링