Cleared up the code#1
Open
FabianSt305 wants to merge 2 commits intoclear-code-projects:mainfrom
FabianSt305:patch-1
Open
Cleared up the code#1FabianSt305 wants to merge 2 commits intoclear-code-projects:mainfrom FabianSt305:patch-1
FabianSt305 wants to merge 2 commits intoclear-code-projects:mainfrom
FabianSt305:patch-1
Conversation
Using Vector2 from vec instead of the pygame version because it supports hashing. Instead of checking each coordinate one at a time, draw_snake does some math and looks up the correct texture in a dict called self.graphics
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You said yourself that you had trouble with the draw_snake logic.
As it now simply looks up the right texture using a dict, it should be a lot easier to understand and reason about.