Skip to content

Feather(Views): add identifier search - #652

Merged
claration merged 2 commits into
claration:mainfrom
ismailcarlik:feat/search-by-bundle-identifier
Jun 5, 2026
Merged

claration merged 2 commits into
claration:mainfrom
ismailcarlik:feat/search-by-bundle-identifier

Conversation

@ismailcarlik

Copy link
Copy Markdown
Contributor

This pull request makes a targeted improvement to the app search functionality. Now, when filtering apps, the search will also consider matches in the app's id field, in addition to name, description, and subtitle.

  • Search functionality improvement:
    • Updated the _calculateSortedApps method in SourceAppsTableRepresentableView.Coordinator to include the app's id field in the search filter, allowing users to find apps by their bundle IDs.

Copilot AI review requested due to automatic review settings May 25, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds app ID matching to the in-table search filter so users can find apps by identifier in addition to name/description fields.

Changes:

  • Extend search predicate to also match app.id.
  • Keep existing search behavior for name/description/subtitle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Feather/Views/Sources/Apps/UIKit/SourceAppsTableRepresentableView.swift Outdated
@claration claration changed the title Add search functionality by bundle identifier in app list Feather(Views): add identifier search Jun 5, 2026
@claration
claration merged commit d308ddd into claration:main Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants