Skip to content

Upgrade solana 2.2.11 for devnet#78

Merged
naviat merged 1 commit intomasterfrom
feature/OPS-4905
Apr 19, 2025
Merged

Upgrade solana 2.2.11 for devnet#78
naviat merged 1 commit intomasterfrom
feature/OPS-4905

Conversation

@naviat
Copy link
Copy Markdown
Contributor

@naviat naviat commented Apr 19, 2025 •
edited by coderabbitai bot
Loading

https://github.com/anza-xyz/agave/releases/tag/v2.2.11

Summary by CodeRabbit

  • Chores
    • Updated the base Docker image to a newer version.
    • Upgraded the Solana geyser plugin to a more recent release.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 19, 2025 •
edited
Loading

Walkthrough

The Dockerfile has been updated to use a newer base image version (anzaxyz/agave:v2.2.11 instead of v2.1.20). Additionally, the version of the yellowstone-grpc Solana geyser plugin downloaded and installed has been changed from v5.0.1+solana.2.1.16 to v6.0.0+solana.2.2.4. The steps for extracting and installing the plugin remain the same, with only the versions and download URLs updated.

Changes

File(s) Change Summary
Dockerfile Updated base image from anzaxyz/agave:v2.1.20 to v2.2.11; updated yellowstone-grpc plugin version and download URL from v5.0.1+solana.2.1.16 to v6.0.0+solana.2.2.4.

Possibly related PRs

Suggested reviewers

  • Maxitosh
  • Spich3000

Poem

A Dockerfile hops to something new,
With agave fresh and plugins too,
Yellowstone-grpc gets a shiny coat,
Solana nodes now stay afloat.
The rabbit grins, its work complete—
Upgrades like these are hard to beat! 🐇🚀

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@guardrails
Copy link
Copy Markdown

guardrails bot commented Apr 19, 2025

⚠️ We detected 1 security issue in this pull request:

Insecure Access Control (1)
Severity Details Docs
High Title: Missing User Instruction

solana-docker/Dockerfile

Line 1 in ebac1ce

FROM anzaxyz/agave:v2.2.11
📚

More info on how to fix Insecure Access Control in Dockerfile.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

coderabbitai[bot]
coderabbitai bot reviewed Apr 19, 2025
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
Dockerfile (2)

1-1: Verify base image bump and compatibility with devnet.

Ensure that anzaxyz/agave:v2.2.11 is published and fully compatible with your devnet setup. For stronger immutability, consider pinning to a digest:

-FROM anzaxyz/agave:v2.2.11
+FROM anzaxyz/agave@sha256:<digest>

This prevents accidental upgrades if the v2.2.11 tag is ever repointed.

Would you like help fetching the SHA256 digest and updating the Dockerfile?

12-12: Harden plugin download with variables and checksum.

To streamline future upgrades and improve security, introduce an ARG for the plugin version and validate the tarball’s integrity:

+ARG YELLOWSTONE_VERSION=v6.0.0+solana.2.2.4
+ARG YELLOWSTONE_SHA256=<expected-sha256>
 RUN mkdir -p /opt/yellowstone-grpc && \
-  curl -L -o /tmp/yellowstone-grpc.tar.bz2 \
-    "https://github.com/rpcpool/yellowstone-grpc/releases/download/v6.0.0+solana.2.2.4/yellowstone-grpc-geyser-release22-x86_64-unknown-linux-gnu.tar.bz2" && \
+  curl -sSLf -o /tmp/yellowstone-grpc.tar.bz2 \
+    "https://github.com/rpcpool/yellowstone-grpc/releases/download/${YELLOWSTONE_VERSION}/yellowstone-grpc-geyser-release22-x86_64-unknown-linux-gnu.tar.bz2" && \
+  echo "${YELLOWSTONE_SHA256}  /tmp/yellowstone-grpc.tar.bz2" | sha256sum -c - && \
   tar -xjf /tmp/yellowstone-grpc.tar.bz2 -C /opt/yellowstone-grpc --strip-components=1 && \
   rm /tmp/yellowstone-grpc.tar.bz2
  • Using -sSLf makes curl fail fast on HTTP errors.
  • Validating the checksum ensures the download wasn’t tampered with.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d30740a and ebac1ce.

📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: guardrails/scan

@naviat naviat merged commit 93f8f59 into master Apr 19, 2025
3 of 4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Maxitosh Maxitosh Maxitosh approved these changes

+1 more reviewer

@Spich3000 Spich3000 Spich3000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naviat @Maxitosh @Spich3000