Skip to content

hw4v2 - Dan Ramos#52

Closed
danramos2015 wants to merge 8 commits into
cewing:masterfrom
danramos2015:master
Closed

hw4v2 - Dan Ramos#52
danramos2015 wants to merge 8 commits into
cewing:masterfrom
danramos2015:master

Conversation

@danramos2015

Copy link
Copy Markdown

Here is Multi-page wsgi app.

regards,

@DanRutz

DanRutz commented Feb 18, 2013

Copy link
Copy Markdown
Collaborator

Hi Dan,

 On the list of open pull requests, your pull request #51 from 13 days ago about week 4 shows up. Sorry that it has been open so long.

 I cloned your repository and ran your code locally and it works fine. I did notice that you’ve got one function for each book, five in all. Can you think of a way to make just one function that can handle all five books? I also noticed that the html is held in variables like body1 and body2, … body5 and I checked and body2 is identical to body1. This is not the way to do this and consolidating these will help you consolidate the function.

 Did you get a chance to get Flaskr running on Flask via following the week 5 lecture? This is one of the assignments. It shouldn’t take too long and might be helpful to you in preparation for reproducing Flaskr in Django. I’ll go ahead and close this pull request so that you can make your next one. Thanks,

—Dan

From: greenlantern203 [mailto:notifications@github.com]
Sent: Tuesday, February 05, 2013 4:13 PM
To: cewing/training.python_web
Subject: [training.python_web] hw4v2 - Dan Ramos (#52)

Here is Multi-page wsgi app.

regards,


You can merge this Pull Request by running

git pull https://github.com/greenlantern203/training.python_web master

Or view, comment on, or merge it at:

#52

@DanRutz DanRutz closed this Feb 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants