Skip to content

Allow cert-manager.io/allow-direct-injection in annotations - #6801

Merged
jetstack-bot merged 1 commit into
cert-manager:masterfrom
jkroepke:allow-secret-injection
Mar 4, 2024
Merged

Allow cert-manager.io/allow-direct-injection in annotations#6801
jetstack-bot merged 1 commit into
cert-manager:masterfrom
jkroepke:allow-secret-injection

Conversation

@jkroepke

@jkroepke jkroepke commented Feb 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request Motivation

#6340 (comment)

Fixes #6361

Kind

feature

Release Note

Allow `cert-manager.io/allow-direct-injection` in annotations

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2024
@jetstack-bot

jetstack-bot commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

Hi @jkroepke. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@jkroepke
Allow cert-manager.io/allow-direct-injection in annotations
818df60 
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
@jkroepke
jkroepke force-pushed the allow-secret-injection branch from cf85dae to 818df60 Compare February 27, 2024 11:26
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 27, 2024
@jkroepke jkroepke mentioned this pull request Feb 27, 2024
Closed
3 tasks
@steiler

steiler commented Feb 28, 2024

Copy link
Copy Markdown

+1

@inteon

inteon commented Mar 4, 2024

Copy link
Copy Markdown
Member

Thanks @jkroepke for the PR.
Quick summary: for cainjector, we have to add the cert-manager.io/allow-direct-injection on the secret so it can be used.
If we want to generate the secret using a Certificate, we have to use the SecretTemplate field, which is a bit too strict currently.
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@inteon

inteon commented Mar 4, 2024

Copy link
Copy Markdown
Member

/cherrypick release-1.14

@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon

inteon commented Mar 4, 2024

Copy link
Copy Markdown
Member

/cherrypick release-1.13

@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon

inteon commented Mar 4, 2024

Copy link
Copy Markdown
Member

/cherrypick release-1.12

@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon

inteon commented Mar 4, 2024

Copy link
Copy Markdown
Member

/retest

@jetstack-bot
jetstack-bot merged commit a7c7868 into cert-manager:master Mar 4, 2024
@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: new pull request created: #6809

Details

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 4, 2024
Merged
Merged
@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: new pull request created: #6810

Details

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot mentioned this pull request Mar 4, 2024
Merged
@jetstack-bot

jetstack-bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@inteon: new pull request created: #6811

Details

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkroepke
jkroepke deleted the allow-secret-injection branch March 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow cert-manager.io/allow-direct-injection annotation on Certificate Secrets

4 participants

@jkroepke @jetstack-bot @steiler @inteon