Skip to content

Commit 3c5c3c4

Browse files
jsorefjsoref
committed
Add acmesolver.runtimeClassName
- Update Runtime Class reference text+link Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
1 parent d38f872 commit 3c5c3c4

5 files changed

Lines changed: 54 additions & 15 deletions

File tree

‎deploy/charts/cert-manager/README.template.md‎

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ The duration the clients should wait between attempting acquisition and renewal
198198
> ""
199199
> ```
200200
201-
A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
201+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
202202
203203
For example:
204204
@@ -786,7 +786,7 @@ affinity:
786786
> ""
787787
> ```
788788
789-
A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
789+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
790790
791791
For example:
792792
@@ -1291,7 +1291,7 @@ affinity:
12911291
> ""
12921292
> ```
12931293
1294-
A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
1294+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
12951295
12961296
For example:
12971297
@@ -1804,7 +1804,7 @@ affinity:
18041804
> ""
18051805
> ```
18061806
1807-
A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
1807+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
18081808
18091809
For example:
18101810
@@ -1997,6 +1997,20 @@ Setting a digest pins the image. If a tag is also set, the rendered reference wi
19971997
> ```
19981998
19991999
Kubernetes imagePullPolicy on Deployment.
2000+
#### **acmesolver.runtimeClassName** ~ `string`
2001+
> Default value:
2002+
> ```yaml
2003+
> ""
2004+
> ```
2005+
2006+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
2007+
2008+
For example:
2009+
2010+
```yaml
2011+
runtimeClassName: gvisor
2012+
```
2013+
20002014
### Startup API Check
20012015
20022016
@@ -2140,7 +2154,7 @@ affinity:
21402154
> ""
21412155
> ```
21422156
2143-
A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
2157+
A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
21442158
21452159
For example:
21462160

‎deploy/charts/cert-manager/templates/deployment.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ spec:
152152
{{- if .Values.disableAutoApproval }}
153153
- --controllers=-certificaterequests-approver
154154
{{- end }}
155+
{{- with .Values.acmesolver.runtimeClassName }}
156+
- --acme-http01-solver-runtime-class-name={{ . | quote }}
157+
{{- end }}
155158
ports:
156159
- containerPort: 9402
157160
name: http-metrics

‎deploy/charts/cert-manager/tests/controller/deployment_test.yaml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -447,3 +447,10 @@ tests:
447447
- equal:
448448
path: spec.template.spec.runtimeClassName
449449
value: something
450+
- it: should set acme-http01-solver-runtime-class-name when acmesolver.runtimeClassName is set
451+
set:
452+
acmesolver.runtimeClassName: something
453+
asserts:
454+
- contains:
455+
path: spec.template.spec.containers[0].args
456+
content: --acme-http01-solver-runtime-class-name="something"

‎deploy/charts/cert-manager/values.schema.json‎

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,9 @@
194194
"properties": {
195195
"image": {
196196
"$ref": "#/$defs/helm-values.acmesolver.image"
197+
},
198+
"runtimeClassName": {
199+
"$ref": "#/$defs/helm-values.acmesolver.runtimeClassName"
197200
}
198201
},
199202
"type": "object"
@@ -249,6 +252,11 @@
249252
"description": "Override the image tag to deploy by setting this variable. If no value is set, the chart's appVersion is used.",
250253
"type": "string"
251254
},
255+
"helm-values.acmesolver.runtimeClassName": {
256+
"default": "",
257+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
258+
"type": "string"
259+
},
252260
"helm-values.affinity": {
253261
"default": {},
254262
"description": "A Kubernetes Affinity, if required. For more information, see [Affinity v1 core](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#affinity-v1-core).\n\nFor example:\naffinity:\n nodeAffinity:\n requiredDuringSchedulingIgnoredDuringExecution:\n nodeSelectorTerms:\n - matchExpressions:\n - key: foo.bar.com/role\n operator: In\n values:\n - master",
@@ -593,7 +601,7 @@
593601
},
594602
"helm-values.cainjector.runtimeClassName": {
595603
"default": "",
596-
"description": "A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)\n\nFor example:\nruntimeClassName: gvisor",
604+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
597605
"type": "string"
598606
},
599607
"helm-values.cainjector.securityContext": {
@@ -955,7 +963,7 @@
955963
},
956964
"helm-values.global.runtimeClassName": {
957965
"default": "",
958-
"description": "A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)\n\nFor example:\nruntimeClassName: gvisor",
966+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
959967
"type": "string"
960968
},
961969
"helm-values.hostAliases": {
@@ -1408,7 +1416,7 @@
14081416
},
14091417
"helm-values.runtimeClassName": {
14101418
"default": "",
1411-
"description": "A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)\n\nFor example:\nruntimeClassName: gvisor",
1419+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
14121420
"type": "string"
14131421
},
14141422
"helm-values.securityContext": {
@@ -1708,7 +1716,7 @@
17081716
},
17091717
"helm-values.startupapicheck.runtimeClassName": {
17101718
"default": "",
1711-
"description": "A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)\n\nFor example:\nruntimeClassName: gvisor",
1719+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
17121720
"type": "string"
17131721
},
17141722
"helm-values.startupapicheck.securityContext": {
@@ -2265,7 +2273,7 @@
22652273
},
22662274
"helm-values.webhook.runtimeClassName": {
22672275
"default": "",
2268-
"description": "A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)\n\nFor example:\nruntimeClassName: gvisor",
2276+
"description": "A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).\n\nFor example:\nruntimeClassName: gvisor",
22692277
"type": "string"
22702278
},
22712279
"helm-values.webhook.securePort": {

‎deploy/charts/cert-manager/values.yaml‎

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ global:
9292
# +docs:property
9393
# retryPeriod: 15s
9494

95-
# A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
95+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
9696
#
9797
# For example:
9898
# runtimeClassName: gvisor
@@ -593,7 +593,7 @@ ingressShim: {}
593593
# - master
594594
affinity: {}
595595

596-
# A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
596+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
597597
#
598598
# For example:
599599
# runtimeClassName: gvisor
@@ -983,7 +983,7 @@ webhook:
983983
# - master
984984
affinity: {}
985985

986-
# A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
986+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
987987
#
988988
# For example:
989989
# runtimeClassName: gvisor
@@ -1375,7 +1375,7 @@ cainjector:
13751375
# - master
13761376
affinity: {}
13771377

1378-
# A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
1378+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
13791379
#
13801380
# For example:
13811381
# runtimeClassName: gvisor
@@ -1515,6 +1515,13 @@ acmesolver:
15151515
# Kubernetes imagePullPolicy on Deployment.
15161516
pullPolicy: IfNotPresent
15171517

1518+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
1519+
#
1520+
# For example:
1521+
# runtimeClassName: gvisor
1522+
# +docs:property
1523+
runtimeClassName: ""
1524+
15181525
# +docs:section=Startup API Check
15191526
# This startupapicheck is a Helm post-install hook that waits for the webhook
15201527
# endpoints to become available.
@@ -1625,7 +1632,7 @@ startupapicheck:
16251632
# - master
16261633
affinity: {}
16271634

1628-
# A Kubernetes Runtime Class, if required. For more information, see [RuntimeClass v1 node](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#runtimeclass-v1-node-k8s-io)
1635+
# A Kubernetes Runtime Class to apply to ACME HTTP01 solver pods, if required. For more information, see [Runtime Class](https://kubernetes.io/docs/concepts/containers/).
16291636
#
16301637
# For example:
16311638
# runtimeClassName: gvisor

0 commit comments

Comments
 (0)