Skip to content

TA-3971: Add option to export packages by versions#239

Merged
Buqeta (Buqeta) merged 3 commits intomasterfrom
TA-3971-add-option-to-export-packages-by-versions
Jul 23, 2025
Merged

TA-3971: Add option to export packages by versions#239
Buqeta (Buqeta) merged 3 commits intomasterfrom
TA-3971-add-option-to-export-packages-by-versions

Conversation

@Buqeta
Copy link
Contributor

@Buqeta Buqeta (Buqeta) commented Jul 18, 2025 •
edited
Loading

Description

  • Added an option to the existing config export command --keysByVersion which exports the packages by the specific received versions.
  • Added logic to check if both versions are being sent or neither of them isn't sent, so the command fails with a message.
  • Used the same batch export logic, just added a check that controls which batch export endpoint will be called based on the received option.
  • Added test cases that are the same as batch export cases.
  • Updated CLI version.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@Buqeta Buqeta (Buqeta) requested a review from a team as a code owner July 18, 2025 14:20
jetakasabaqi
Jeta (jetakasabaqi) reviewed Jul 21, 2025
View reviewed changes
ksalihu
Kastriot Salihu (ksalihu) reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@ksalihu Kastriot Salihu (ksalihu) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the command should be config versions export {resource} {action}

@Buqeta
Copy link
Contributor Author

Buqeta (Buqeta) commented Jul 23, 2025

I think the command should be config versions export {resource} {action}

We're technically exporting packages. The version is just a property of the package. I don't think it's a resource on its own. This structure you're proposing is also confusing to the CLI user since the config export exports packages and it doesn't have the packages name in the command.

ZgjimHaziri
Zgjim Haziri (ZgjimHaziri) reviewed Jul 23, 2025
View reviewed changes
@ZgjimHaziri
Copy link
Contributor

Zgjim Haziri (ZgjimHaziri) commented Jul 23, 2025

We're technically exporting packages. The version is just a property of the package. I don't think it's a resource on its own. This structure you're proposing is also confusing to the CLI user since the config export exports packages and it doesn't have the packages name in the command.

The main point here is that the existing export command is not in a proper structure.

@Buqeta Buqeta (Buqeta) merged commit 624b023 into master Jul 23, 2025
1 check passed
@Buqeta Buqeta (Buqeta) deleted the TA-3971-add-option-to-export-packages-by-versions branch July 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksalihu Kastriot Salihu (ksalihu) ksalihu left review comments

@jetakasabaqi Jeta (jetakasabaqi) jetakasabaqi approved these changes

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) ZgjimHaziri approved these changes

@promeris Meris Nici (promeris) promeris left review comments

@LaberionAjvazi Laberion Ajvazi (LaberionAjvazi) LaberionAjvazi left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Buqeta @ZgjimHaziri @jetakasabaqi @promeris @LaberionAjvazi @ksalihu