Skip to content

Add client config options#3

Merged
griffinmyers merged 2 commits intomasterfrom
will/config
Dec 1, 2016
Merged

Add client config options#3
griffinmyers merged 2 commits intomasterfrom
will/config

Conversation

@griffinmyers
Copy link
Copy Markdown
Contributor

Description

Adding support for a config hash which may be supplied as an optional 2nd argument to the Button::Client#new. This adds support for configurable hostname, port, timeout, and protocol. This should be entirely backwards compatible.

Copy link
Copy Markdown

@danielmcgrath danielmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -1,3 +1,3 @@
module Button
VERSION = '1.0.0'.freeze
VERSION = '1.0.1'.freeze
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0 for new functionality

@griffinmyers
Copy link
Copy Markdown
Contributor Author

thanks @danielmcgrath !

@griffinmyers griffinmyers merged commit 9c41e84 into master Dec 1, 2016
@griffinmyers griffinmyers deleted the will/config branch December 1, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants