Skip to content

Conversation

@agluszak
Copy link
Collaborator

No description provided.

@agluszak agluszak requested a review from adpi2 as a code owner October 11, 2024 16:30
Comment on lines 23 to 24
"https://bcr.bazel.build/modules/aspect_rules_lint/1.0.0-rc10/MODULE.bazel": "43df678221c15a8d44a72f6496842238bd9612c97d024c145ef97c776534af0b",
"https://bcr.bazel.build/modules/aspect_rules_lint/1.0.0-rc10/source.json": "5e55a8d8b68f2f3412d2bd06e53eebed70e811a7681819305275398e90542768",
"https://bcr.bazel.build/modules/aspect_rules_lint/1.0.0-rc8/MODULE.bazel": "7c119c96df01e97ed8501ad319a26f29c975e22121d06fae3e88be5d0a0e96ee",
"https://bcr.bazel.build/modules/aspect_rules_lint/1.0.0-rc8/source.json": "0c87d888e7b38d2cb2cf051003579fb75ab68889ef7d4f2ea22e800b262823c4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a downgrade?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downgrade is intentional because Andrzej found a possible formater bug in rules_lint
aspect-build/rules_lint#413

same for removed lines. trying to investigate the bug in rules_lint, because its not reproducible there, me or Andrzeh will get back in a few days to this PR once its more clear what's up with rules_lint behaviour

@@ -1,19 +1,15 @@
package ch.epfl.scala.util

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change is causing all this removed lines?

helps fix branch with bumps
made some more updates to existing bumps in the branch
restored removed lines in Scala files
bumped more dependencies and bazel version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants