Conversation
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
d4dd9b4 to
693b99f
Compare
bpg-dev
reviewed
Nov 27, 2025
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
bpg-dev
reviewed
Nov 30, 2025
bpg-dev
requested changes
Nov 30, 2025
Member
bpg-dev
left a comment
There was a problem hiding this comment.
Hey @simoncaron 👋🏼
Looks like there are few more issues with the code, see my comments.
After fixing them, I tried to run the tests, but got theses errors:
=== NAME TestAccResourceOCIImage/missing_reference
resource_oci_image_test.go:278: Step 1/1, expected an error with pattern, no match on: Error running apply: exit status 1
Error: Error downloading file from url
with proxmox_virtual_environment_oci_image.test_image,
on terraform_plugin_test.tf line 25, in resource "proxmox_virtual_environment_oci_image" "test_image":
25: resource "proxmox_virtual_environment_oci_image" "test_image" {
Could not download file '.tar', unexpected error: error download OCI image by
reference: received an HTTP 400 response - Reason: Parameter verification
failed. (reference: value does not match the regex pattern - filename: value
must be at least 1 characters long)
=== NAME TestAccResourceOCIImage/override_behavior
resource_oci_image_test.go:278: Step 3/3 error: Pre-apply plan check(s) failed:
'proxmox_virtual_environment_oci_image.test_override' - expected DestroyBeforeCreate, got action(s): [update]
Would you be able to take a look?
| }{ | ||
| {"missing reference", []resource.TestStep{{ | ||
| Config: te.RenderConfig(` | ||
| resource "proxmox_oci_image" "test_image" { |
Member
There was a problem hiding this comment.
proxmox_oci_image won't work, should be proxmox_virtual_environment_oci_image
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
Signed-off-by: Simon Caron <8635747+simoncaron@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
bpg-dev
approved these changes
Dec 6, 2025
Member
bpg-dev
left a comment
There was a problem hiding this comment.
Thanks a lot @simoncaron!
Everything is 👌🏼, i just made a few small cleanups on top of your changes.
LGTM! 🚀
proxmox_virtual_environment_oci_image resource for OCI Images Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement OCI image pulling for PVE 9.1.
Contributor's Note
/docsfor any user-facing features or additions./fwprovider/testsfor any new or updated resources / data sources.make exampleto verify that the change works as expected.Proof of Work
Community Note
Closes #2369