fix(desktop): accept ACP config option name labels - #6545
Open
unclejobs-ai wants to merge 1 commit into
Open
Conversation
Signed-off-by: EungjePark <patreot0312@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefield for config-option and select-value labels.displayNamefield as the first choice for backward compatibility.ACP v1 defines
nameas the required human-readable label for bothConfigOptionandConfigOptionValue: https://github.com/agentclientprotocol/agent-client-protocol/blob/main/docs/protocol/v1/session-config-options.mdxBuzz previously read only the non-standard
displayNamefield. Agents that follow the spec, including Cursor ACP, therefore exposed raw values such asdefault[]instead of their advertised label (Auto).Related issue
N/A — no matching open issue or PR found.
Testing
just desktop-tauri-testjust desktop-tauri-clippyjust desktop-tauri-fmt-checkcargo test --manifest-path desktop/src-tauri/Cargo.toml config_options_accept_acp_name_labels --libcargo test --manifest-path desktop/src-tauri/Cargo.toml agent_model_normalization_accepts_acp_name_field --libgit diff --checkBefore / after
default[]value is shown raw.name,Auto.