Add Security Mode setting and image blocking - #929
Open
arcobaleno64 wants to merge 1 commit into
Open
arcobaleno64 wants to merge 1 commit into
arcobaleno64 wants to merge 1 commit into
Conversation
Introduce a Security Mode preference to block external images and remote content by default. Adds IsSecurityModeEnabled to IPreferencesService and PreferencesService (and excludes it from syncable/exported properties to avoid silent security downgrades). Update MailRenderingPageViewModel to honor the setting, expose a contextual info bar message, and refresh UI bindings; update MailRenderingPage.xaml and settings page to display the message and toggle. Add translations and comprehensive tests for the security mode and HTML ClearImages sanitization. Also add .omc/ to .gitignore.
Collaborator
|
There already such settings, what this PR for? |
Owner
|
Discussion for this PR is here #948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a Security Mode preference to block external images and remote content by default. Adds IsSecurityModeEnabled to IPreferencesService and PreferencesService (and excludes it from syncable/exported properties to avoid silent security downgrades). Update MailRenderingPageViewModel to honor the setting, expose a contextual info bar message, and refresh UI bindings; update MailRenderingPage.xaml and settings page to display the message and toggle. Add translations and comprehensive tests for the security mode and HTML ClearImages sanitization. Also add .omc/ to .gitignore.