[PM-37932] Recover browser IPC after process reload#20848
Draft
coroiu wants to merge 1 commit into
Draft
Conversation
Re-inject the IPC content script into already-open tabs when the service worker starts up. After a process reload (`chrome.runtime.reload()`), tabs opened before the reload retain a content script bound to the previous extension context, leaving the IPC bridge dead until a full page reload. The old instance now tears itself down via a long-lived port's onDisconnect so the freshly injected script can register its listeners without duplicating handlers.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20848 +/- ##
==========================================
- Coverage 47.81% 47.80% -0.01%
==========================================
Files 4006 4006
Lines 123309 123331 +22
Branches 18966 18969 +3
==========================================
+ Hits 58963 58964 +1
- Misses 59901 59922 +21
Partials 4445 4445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-inject the IPC content script into already-open tabs when the service worker starts up. After a process reload (
chrome.runtime.reload()), tabs opened before the reload retain a content script bound to the previous extension context, leaving the IPC bridge dead until a full page reload. The old instance now tears itself down via a long-lived port's onDisconnect so the freshly injected script can register its listeners without duplicating handlers.🎟️ Tracking
📔 Objective
📸 Screenshots