Added support for the empty arguments passed to the command#20
Merged
bitsofinfo merged 3 commits intobitsofinfo:masterfrom Sep 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for explicitly passing empty string values to PowerShell command arguments when configured to allow them. Previously, empty string arguments were filtered out and not included in generated commands.
- Added
emptyproperty configuration to allow empty string values for specific command arguments - Modified argument processing logic to include empty strings when explicitly allowed
- Added comprehensive test coverage and documentation for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| psCommandService.js | Core logic changes to support empty argument values via new isEmpty flag |
| test/unit.js | Added test configuration and comprehensive test case for empty value support |
| README.md | Added documentation and version history for the new empty arguments feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bmudda-wpp
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for explicitly passing empty string values to PowerShell command arguments when configured to allow them. Previously, empty string arguments were filtered out and not included in generated commands. This enhancement provides more flexibility for PowerShell cmdlets that distinguish between omitted parameters and explicitly empty parameters.
The need has originated from the ability to remove the value set for certain properties this is the way to do it via Powershell.
Test coverage has been added to cover the addition.
Change is a nonbreaking change ensuring existing implementation will not break upon upgrade.
Example:
Currently generating:
Set-Content -Path './test.txt' -Filter '*.txt'Desired output:
Set-Content -Path './test.txt' -Value '' -Filter '*.txt'This is archived by marking argument
Filterasemptyin the commend definition.