Fix #1079: Use isEmpty() instead of size() == 0 #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, Thanks! |
Contributor
|
I tried re-running but it failed again. It looks like a problem with the SCOP external resource. I'll try again later. |
Contributor
|
I've run tests locally and it works fine. I'll merge it. |
Contributor
Author
|
Thank you for manually merging the PR. I’ve noticed the additional comments from @jlerbsc. If you would like, please reopen the ticket and assign it to me. |
Contributor
|
Good point, just reopened. It was closed automatically by github with this PR. |
Contributor
|
Hi @Pasjonat90D Have you tried using indepth to automatically fix these defects? |
Contributor
Author
|
Hi @jlerbsc, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079