Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates scikit-learn to the most recent version.
It is the first time I've contributed to this repo 👋 Interested to see what happens/breaks with the newest version. As a scikit-learn maintainer it makes me happy if people are using the latest version of scikit-learn. All the work that has gone into it should benefit someone :D
How do I use the comment above the scikit-learn entry in the requirements file to find out what it is referring to? I guess it is referencing a bug or discussion somewhere? I had a brief look at the
learntoolsPyPI page and there hasn't been a release in about two years. This probably explains why it doesn't work with new versions of scikit-learn. What is the process for figuring out when to favour newer scikit-learn versions over keeping learntools? Keeping packages that used to be part of the image is useful, but having new versions of other packages is also useful. So we need some kind of tradeoff :-/