allow manual redis connection#708
Conversation
compwright
left a comment
There was a problem hiding this comment.
Thank you for this contribution! I think it would be a bit more user-friendly to call the new option autoConnect and default it to true. If you don't want auto connection then you would manually set the option to false and call queue.connect(). Would you make this change for me?
|
@billyen2012 also please note the failing CI checks. You need to edit the commit message for all commits on this branch to comply with this standard: https://github.com/conventional-changelog/commitlint/#what-is-commitlint |
b55330b to
b94b43b
Compare
b94b43b to
1accf5d
Compare
Suggested change has been applied |
Opps, I was unaware that I suppose to use should be okay now I also notice that sometimes the test will failed because when all the test suite are executed together, it will just make redis dropping connection. Not sure if it was just the issue of my redis, but I will suggest the following change to make the test more stable. (this is not in this PR)
|
## [1.6.0](v1.5.0...v1.6.0) (2023-11-02) ### Features * **queue:** allow manual connection ([#708](#708)) ([425fb89](425fb89))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hey, this is a super awesome queue library.
I'm working on a
next.jsproject and found that whenever I try to build the project, the build process will failed becauseQueueis try to connect to the redis host for some reasons.Not sure if it is because the logic of connection to redis host is in the constructor of the
Queue, but be able manually connect to redis seems to solve the problem.So here is the pull request basically allowing user to manual connect to redis by calling
queue.connect()afterQueueinstance is created.