Skip to content

Upgrade redis to 3.0.2#257

Closed
b-jam wants to merge 1 commit intobee-queue:masterfrom
b-jam:master
Closed

Upgrade redis to 3.0.2#257
b-jam wants to merge 1 commit intobee-queue:masterfrom
b-jam:master

Conversation

@b-jam
Copy link

@b-jam b-jam commented May 31, 2020

Fixes #253

@b-jam
Copy link
Author

b-jam commented May 31, 2020

Unsure why CI is failing, but it works for me in an app using TLS, and yarn test runs fine locally

@bradvogel bradvogel requested a review from skeggse June 1, 2020 00:22
@skeggse
Copy link
Member

skeggse commented Jun 1, 2020

This project uses npm - please use npm to upgrade redis as that'll avoid the yarn.lock and will update the package-lock.json. CI is failing because the two package files aren't in sync.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db0d287 on b-jam:master into 3430506 on bee-queue:master.

@b-jam
Copy link
Author

b-jam commented Jun 1, 2020

Ah. It looks better now, but incompatible with node 4 so that checks failing still

@b-jam
Copy link
Author

b-jam commented Jun 1, 2020

Hey @skeggse is it important to keep node 4 happy, or can I perhaps remove it from travis, and add a lts like lts/erbium ?

@skeggse
Copy link
Member

skeggse commented Jun 1, 2020

We'll have to wait to deprecate Node 4 support for bee-queue v2, which is currently on hold pending an owner.

@b-jam
Copy link
Author

b-jam commented Jun 1, 2020

Sure, can I merge this into 2.0dev then instead ?

@b-jam
Copy link
Author

b-jam commented Jun 1, 2020

Nevermind - I see thats using ioredis anyway

@skeggse
Copy link
Member

skeggse commented Jun 1, 2020

One of 2.0's main features is moving to ioredis, so I'm not sure that's the right move. Did Redis 3 drop Node 4 support?

If this is something you want internally, you should be able to just pass a Redis 3 connection in to the Queue constructor.

@b-jam
Copy link
Author

b-jam commented Jun 1, 2020

https://github.com/NodeRedis/node-redis/blob/master/.github/workflows/tests.yml
looks like it judging from their CI which only runs v6+

ah that sounds like a better solution than forking. Will check it out

@b-jam
Copy link
Author

b-jam commented Jun 9, 2020

As a note, I tried using a 3.0 connection but it just didn't work. Didn't do a deep dive why, just that it didn't work after I changed it to a 3.0 connection to the same redis, TLS or not.

I will patiently wait for bq 2.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use rediss TLS url - upgrade node-redis version

3 participants

Comments