If the brpoplpush commands fails, wait before retrying#162
If the brpoplpush commands fails, wait before retrying#162compwright merged 3 commits intobee-queue:masterfrom
Conversation
|
Thanks @tmeasday. I'm open to merging this in. Would you give it a rebase please? |
45a4816 to
a96e218
Compare
39094a3 to
9d9f0c8
Compare
9d9f0c8 to
2bc0b17
Compare
|
@compwright - done. Not sure what's happening with the failing test run. |
|
@bradvogel I need to override the merge restriction here, the failure is due to a dev dependency no longer being supported on Node < 12, and all tests are passing. |
|
@compwright I raised you permission level to "Maintain". Do you have access now to fix CI to remove the old Node version? |
|
@bradvogel I can edit the CI config file to remove the old versions no problem. I cannot edit the branch protections however to remove those old version checks from being required. I need to be a repo admin for that. |
|
@compwright I just removed all Node versions < 12 from the CI check. This can now be merged. |
## [1.4.1](v1.4.0...v1.4.1) (2022-11-22) ### Bug Fixes * If the brpoplpush commands fails, wait before retrying ([#162](#162)) ([657eb1f](657eb1f))
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The current behaviour is to retry as fast as possible, leading to a spam of commands and error messages if the redis instance is for example unavailable for a brief period. It seems more sensible to take a bit more care in retrying.