Add additional tests from OpenWall implementation sources#84
Closed
Oscil8 wants to merge 1 commit intobcrypt-ruby:masterfrom
Closed
Add additional tests from OpenWall implementation sources#84Oscil8 wants to merge 1 commit intobcrypt-ruby:masterfrom
Oscil8 wants to merge 1 commit intobcrypt-ruby:masterfrom
Conversation
reedloden
added a commit
to reedloden/bcrypt-ruby
that referenced
this pull request
Mar 11, 2014
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
reedloden
added a commit
to reedloden/bcrypt-ruby
that referenced
this pull request
Mar 11, 2014
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
reedloden
added a commit
to reedloden/bcrypt-ruby
that referenced
this pull request
Mar 11, 2014
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
Contributor
|
status? can be closed? |
|
It's not merged, so no. Though, I did include the changes in #91. |
Author
|
Yeah, the tests still show a probable issue; although the issue is likely in jBCrypt. I may have time next month to do some more debugging to try to identify the issue. |
Contributor
|
Great! |
Author
|
The jBCrypt issues appear to be due to character encoding due to use of Java's String.getBytes on input. Suggestion would be to pass byte[] array directly -- see POC at https://github.com/Oscil8/bcrypt-ruby/tree/wip/jruby-fix which does pass tests in either jruby or MRI. |
See http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/BF_fmt.c Note that these tests pass on MRI 1.8/1.9 but fail on jruby, the bugs are due to character encoding on input to the jBCrypt implementation.
reedloden
added a commit
to reedloden/bcrypt-ruby
that referenced
this pull request
Feb 12, 2015
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
samcday
pushed a commit
to atlassian/bcrypt-ruby
that referenced
this pull request
Feb 15, 2017
* Fixes bcrypt-ruby#39, bcrypt-ruby#80 * Include new tests from upstream (fixes bcrypt-ruby#84)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/BF_fmt.c
Note that these tests pass on MRI 1.8/1.9 but fail on jruby, the
bugs are likely in the jBCrypt implementation.
This is related to #82.