Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: franckverrot/activevalidators
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: bcm/activevalidators
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 4, 2016

  1. ensure a non-nil error message for invalid emails and phone numbers

    I found that I needed to add this because my email validity tests were
    failing without it. using shoulda-matchers, I wrote the following test
    with rspec:
    
    ```
    it { is_expected.not_to allow_value('foo').for(:contact_email) }
    ```
    
    the test failed when shoulda-matchers raised a TypeError with message
    `can't dup NilClass`. tracing this I found that after calling `valid?`
    on my record, the AM::Errors object had this error:
    
    ```
    :contact_email => [
     [0] nil
    ]
    ```
    
    for some reason passing a nil message to AM:Errors#add was not resulting
    in the default `:invalid` message. this patch, however, makes things
    work as expected.
    
    it's not clear to me why the invalid error message test in this library
    passed before. but it's still passing now, and my application works as
    expected.
    bcm committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    f0b4f40 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from bcm/email-default-message-fix

    ensure a non-nil error message for invalid emails and phone numbers
    bcm authored Jul 4, 2016
    Configuration menu
    Copy the full SHA
    2d6ff7b View commit details
    Browse the repository at this point in the history
  3. bump version to 3.3.0.maz.1

    bcm committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    69e8ee7 View commit details
    Browse the repository at this point in the history
  4. Update to credit_card_validations 3.2.2

    for compatibility with Rails 5
    bcm committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    facdd22 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    225412b View commit details
    Browse the repository at this point in the history
  6. bump version to 3.3.0.maz.2

    bcm committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    f4dd487 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2017

  1. Configuration menu
    Copy the full SHA
    9ddfb44 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2017

  1. Configuration menu
    Copy the full SHA
    09a0bd8 View commit details
    Browse the repository at this point in the history
  2. allow Countries 2.x

    bcm committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    12dedeb View commit details
    Browse the repository at this point in the history
  3. turn off gem signing

    bcm committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    bad57c6 View commit details
    Browse the repository at this point in the history
Loading