Skip to content

Tighten ESLint workflow behavior and clean up bug report metadata examples#49

Merged
JosunLP merged 4 commits intoJosunLP-patch-1from
copilot/sub-pr-45
Mar 12, 2026
Merged

Tighten ESLint workflow behavior and clean up bug report metadata examples#49
JosunLP merged 4 commits intoJosunLP-patch-1from
copilot/sub-pr-45

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 12, 2026

This updates the follow-up fixes for the labeler/docs automation PR by addressing the remaining review comments in the ESLint workflow and issue template. The changes keep lint reporting aligned with the repo’s existing Actions conventions and make the bug template less ambiguous for reporters.

  • ESLint workflow

    • switch SARIF upload to github/codeql-action/upload-sarif@v4 to match the repo’s CodeQL action version
    • make lint failures block push/pull_request runs while keeping scheduled scans non-blocking
    • remove the workspace-mutating formatter install step from CI
    • use a single lint step with conditional continue-on-error to avoid duplicated command paths
  • Bug report template

    • replace incorrect/outdated OS/device examples with realistic desktop and mobile examples
    • normalize field labels (Browser:, App version:) for consistent issue intake formatting
  • Workflow behavior change

    • PR/push runs now fail on lint regressions, while scheduled runs still upload SARIF without turning the schedule into a hard gate
- name: Run ESLint
  continue-on-error: ${{ github.event_name == 'schedule' }}
  run: |
    bunx --bun -p @microsoft/eslint-formatter-sarif@3.1.0 eslint . \
      --format @microsoft/eslint-formatter-sarif \
      --output-file eslint-results.sarif

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 12, 2026 15:43
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Copilot AI changed the title [WIP] Add contributor guidance and improve documentation in bQuery.js Tighten ESLint workflow behavior and clean up bug report metadata examples Mar 12, 2026
@JosunLP JosunLP marked this pull request as ready for review March 12, 2026 15:49
Copilot AI review requested due to automatic review settings March 12, 2026 15:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ESLint GitHub Actions workflow to better align with existing repo CI conventions (Bun + CodeQL v4) while refining the bug report issue template to reduce ambiguity for reporters.

Changes:

  • Adjust ESLint workflow to upload SARIF via github/codeql-action/upload-sarif@v4, avoid workspace mutation, and only allow scheduled lint to be non-blocking.
  • Consolidate lint execution into a single step using conditional continue-on-error for scheduled runs.
  • Refresh bug report template environment examples and normalize field labels.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/eslint.yml Makes PR/push lint failures blocking, keeps scheduled runs non-blocking, and aligns SARIF upload with CodeQL v4.
.github/ISSUE_TEMPLATE/bug_report.md Updates environment metadata examples/labels for clearer and more consistent bug reports.

@JosunLP
Copy link
Copy Markdown
Collaborator

JosunLP commented Mar 12, 2026

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot apply changes based on the comments in this thread

Applied in 9b70c7b. The bug template now asks for bQuery version (@bquery/bquery) in both Desktop and Smartphone sections so reporters provide the library/package version instead of an ambiguous app version. No UI changes were involved.

@JosunLP JosunLP merged commit b1ebad1 into JosunLP-patch-1 Mar 12, 2026
2 checks passed
@JosunLP JosunLP deleted the copilot/sub-pr-45 branch March 12, 2026 16:01
Copilot stopped work on behalf of JosunLP due to an error March 12, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants