fix(ci): align ESLint workflow with repo CI conventions#47
Merged
JosunLP merged 2 commits intoJosunLP-patch-1from Mar 12, 2026
Merged
fix(ci): align ESLint workflow with repo CI conventions#47JosunLP merged 2 commits intoJosunLP-patch-1from
JosunLP merged 2 commits intoJosunLP-patch-1from
Conversation
Merged
…devDependencies, remove deprecated --ext flag Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve documentation and workflow automation in bQuery.js
fix(ci): align ESLint workflow with repo CI conventions
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the ESLint CI workflow to align with the repository's established CI conventions (matching test.yml and npm-publish.yml). It replaces ad-hoc Bun installation via npm with the standard oven-sh/setup-bun@v2 action, uses a frozen lockfile install, and removes the deprecated --ext ESLint flag.
Changes:
- Replace
npm install bun -g/bun iwithoven-sh/setup-bun@v2(bun-version1.3.7) +bun install --frozen-lockfile - Move
@microsoft/eslint-formatter-sariffrom ad-hoc CI install intodevDependencies(package.json + bun.lock) - Drop deprecated
--ext .js,.jsx,.ts,.tsxflag incompatible with ESLint v9 flat config
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/eslint.yml |
Align Bun setup, dependency install, and ESLint invocation with repo CI conventions |
package.json |
Add @microsoft/eslint-formatter-sarif to devDependencies |
bun.lock |
Lock the newly added dev dependency |
JosunLP
added a commit
that referenced
this pull request
Mar 12, 2026
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonas Pfalzgraf <info@josunlp.de> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Fix PR review issues: duplicate keys, cleanup leaks, export conflicts, and SSR safety (#17) Fix security, type safety, and API surface issues from PR #16 review (#18) Fix router cancellation, component example, and ref directive expression handling (#19) Fix router compatibility, isDev default, style cleanup, and changelog format (#20) Fix hash routing bugs and add comprehensive test coverage (#21) Fix router base path handling, bq-if DOM stability, and CHANGELOG consistency (#22) Fix defineComponent tests, store reactivity leak, view directive signal handling, and hash-routing interception (#24) Fix async handling, type safety, environment guards, and add test coverage from PR #16 review (#25) Fix DOM order reversal, stale dependency tracking, localStorage SafariError, and reactive bq-for updates (#26) Fix view template root validation, store optimizations, and utils API cleanup (#27) Fix bq-show display restoration and timeline.seek() time calculation (#28) Fix router base path duplication and add SSR guards for Element checks (#29) Fix interceptLinks() browser behavior and createTemplate() validation (#30) Fix bq-class bracket detection, once() failure caching, mount bq-for validation, and component pre-mount renders (#31) Fix bq-style whitespace handling and spring variable frame rate (#32) Fix bq-on method reference context loss and remove style attribute from security defaults (#33) Fix persistedSignal localStorage test key collision (#34) Fix bq-class directive stale class cleanup for object syntax (#35) Fix timeline() to account for animation iterations in duration calculations (#36) fix: Reactive robustness, security hardening, storage compat, expression parsing (#37) Fix css() getter, add Signal.dispose(), debounce/throttle cancel, collection.find(), element.is() (#39) fix(ci): align ESLint workflow with repo CI conventions (#47) fix: repair corrupted bun.lock breaking CI frozen-lockfile installs (#48) Fix ESLint workflow failure caused by SARIF formatter runtime mismatch (#50)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESLint workflow deviated from repo CI standards: it installed Bun via npm, ran a non-frozen dependency install, and added
@microsoft/eslint-formatter-sarifas an ad-hoc runtime package. It also passed the deprecated--extflag incompatible with ESLint v9 flat config.Changes
npm install bun -g+bun iwithoven-sh/setup-bun@v2(bun-version: 1.3.7) +bun install --frozen-lockfile, matchingtest.ymlandnpm-publish.yml@microsoft/eslint-formatter-sarif@^3.1.0from ad-hocbun installduring CI intodevDependenciesinpackage.jsonandbun.lock; installed reproducibly via the frozen lockfile step--ext .js,.jsx,.ts,.tsx— deprecated in ESLint v9 flat config; file globs are already defined ineslint.config.js💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.