Add explanatory comment for protocol-relative URL check in sanitizer#13
Merged
JosunLP merged 3 commits intodevelopmentfrom Jan 24, 2026
Merged
Add explanatory comment for protocol-relative URL check in sanitizer#13JosunLP merged 3 commits intodevelopmentfrom
JosunLP merged 3 commits intodevelopmentfrom
Conversation
Merged
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Version 1.1.2 pull request
Add explanatory comment for protocol-relative URL check in sanitizer
Jan 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the documentation around the URL sanitization logic by clarifying why the protocol-relative // check in isExternalUrl() is critical to security correctness.
Changes:
- Added an explicit comment explaining the need for an early return on protocol-relative URLs.
- Documented the security rationale to discourage future refactors that might move or remove the
//guard.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #12 regarding the protocol-relative URL early return in
isExternalUrl().Changes
//check at line 366 is critical for correctness, not optimizationURLconstructor, where they could be incorrectly resolved withwindow.location.hrefas baseThis prevents future maintainers from inadvertently removing or relocating the check, which would introduce security classification bugs.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.