Use safe keyword when hook target namspace clashes with reserved java…#426
Merged
Brianwithay21 merged 1 commit intoaws-cloudformation:masterfrom Sep 22, 2023
Merged
Conversation
setttings
approved these changes
Sep 21, 2023
razcloud
approved these changes
Sep 22, 2023
minhphuong98
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… keywords
Issue #, if available:
Description of changes:
Using a safe keyword that appends a
_to the end of a nampspace if it is a reservered keyword in Java. This is updated for when generating POJOs for a Resource Hooks targets.For example, the
AWS::Panorama::Packageresource was generating the following path:Now a underscore is added so there is no name clashing causing complication errors for these certain resource types:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.