Enable pre-heat for PMSx003 sensors#35
Merged
avaldebe merged 1 commit intoavaldebe:masterfrom Dec 7, 2022
Merged
Conversation
benthorner
commented
Dec 6, 2022
|
|
||
| ALIASES = ("PMS1003", "G1", "PMS5003", "G5", "PMS7003", "G7", "PMSA003", "G10") | ||
|
|
||
| PREHEAT = 10 # 10 seconds |
Contributor
Author
There was a problem hiding this comment.
Since this observation is only for PMSA003, would it make more sense to create a pmsa003.py module to keep the change isolated to that sensor?
Owner
There was a problem hiding this comment.
It might be mentioned only on the PMSA003, but it seems to me that this should affect all Plantower sensors that support sleep/wake commands.
The PMSA003 sensor takes approximately 10 seconds to warm up, with
InconsistentObservation and WrongMessageFormat exceptions raised for
earlier samples. From experimentation, 10 seconds is almost exactly
the warm up time, but the datasheet actually recommends 30s [^1]:
Stable data should be got at least 30 seconds after the sensor wakeup from the sleep mode because of the fan’s performance.
However, it makes sense to set this number based on what happens in
practice; we can always increase if others observe worse behaviour.
[^1]: https://cdn.shopify.com/s/files/1/0176/3274/files/PMSA003_datasheet.pdf?v=1619703
eb7154d to
a00176d
Compare
Contributor
Author
|
Hi @avaldebe, just one last PR from me. It's fairly optional from my perspective, but I thought you'd be interested in the behaviour of this sensor, at least. |
avaldebe
approved these changes
Dec 7, 2022
Owner
avaldebe
left a comment
There was a problem hiding this comment.
Thanks for this and your previous PRs, and thanks for your patience dealing with my pickiness.
benthorner
added a commit
to benthorner/snsary
that referenced
this pull request
Dec 7, 2022
This is a viable replacement for PMSx003 sensors since [^1]. It makes sense to embed warm up knowledge in the PyPMS repository, rather than pushing the warm up time decision forward. [^1]: avaldebe/PyPMS#35
Contributor
Author
|
Thanks Alvaro 🙂 |
benthorner
added a commit
to benthorner/snsary
that referenced
this pull request
Dec 9, 2022
This is a viable replacement for PMSx003 sensors since [^1]. It makes sense to embed warm up knowledge in the PyPMS repository, rather than pushing the warm up time decision forward. [^1]: avaldebe/PyPMS#35
benthorner
added a commit
to benthorner/snsary
that referenced
this pull request
Dec 9, 2022
This is a viable replacement for PMSx003 sensors since [^1]. It makes sense to embed warm up knowledge in the PyPMS repository, rather than pushing this one bit of implementation to consumers. [^1]: avaldebe/PyPMS#35
benthorner
added a commit
to benthorner/snsary
that referenced
this pull request
Dec 9, 2022
This is a viable replacement for PMSx003 sensors since [^1]. It makes sense to embed warm up knowledge in the PyPMS repository, rather than pushing this one bit of implementation to consumers. [^1]: avaldebe/PyPMS#35
Contributor
Author
Owner
|
just came fro holidays, will deal with this today/tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PMSA003 sensor takes approximately 10 seconds to warm up, with
InconsistentObservation and WrongMessageFormat exceptions raised
for earlier samples. From experimentation, 10 seconds is almost exactly
the warm up time, but the datasheet actually recommends 30s 1:
However, it makes sense to set this number based on what happens in
practice; we can always increase if others observe worse behaviour.
Footnotes
https://cdn.shopify.com/s/files/1/0176/3274/files/PMSA003_datasheet.pdf?v=1619703 ↩