Fix for #19 updated all calls to getBytes or new String to pass a C...#25
Closed
thaggie wants to merge 1 commit intoauth0:masterfrom
thaggie:issue-19-charsets
Closed
Fix for #19 updated all calls to getBytes or new String to pass a C...#25thaggie wants to merge 1 commit intoauth0:masterfrom thaggie:issue-19-charsets
thaggie wants to merge 1 commit intoauth0:masterfrom
thaggie:issue-19-charsets
Conversation
…a Charset of UTF-8
Contributor
|
Thanks @thaggie. This will be merged and added in the next major version as it's a potentially breaking change. Afterwards, we will add overloads in each method to allow specifying the charset manually and using |
|
I suggest #49 instead as StandardCharsets.UTF_8 is a standard java constant now |
a60d9c9 to
111023b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...harset of UTF-8