Skip to content

Conversation

@pllim
Copy link
Member

@pllim pllim commented Dec 22, 2025

Description

This pull request is to fix #19084 .

No need to run CI. If RTD turns green, I am just going to merge without review to unblock all other PRs. That said, if a review comes in before then, that is also nice.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v7.2.1 milestone Dec 22, 2025
@pllim pllim added Docs 🔥 Critical no-changelog-entry-needed backport-v7.2.x on-merge: backport to v7.2.x labels Dec 22, 2025
@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim merged commit 92c48c8 into astropy:main Dec 22, 2025
3 checks passed
@pllim pllim deleted the fix-np-2.4-bad-docs branch December 22, 2025 17:43
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 22, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, np doesn't follow the double backticking but anyway I recall running into issues with inherited docstrings where not all the references are available for the child.

pllim added a commit that referenced this pull request Dec 22, 2025
…085-on-v7.2.x

Backport PR #19085 on branch v7.2.x (DOC: Add nitpick-exceptions for numpy 2.4 inherited docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: RTD is failing with 3 warnings

2 participants